Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix data race of TestRaftClusterMultipleRestart #7392

Merged
merged 1 commit into from
Nov 20, 2023
Merged

*: fix data race of TestRaftClusterMultipleRestart #7392

merged 1 commit into from
Nov 20, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 20, 2023

What problem does this PR solve?

Issue Number: Close #7391

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 20, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2023
@rleungx rleungx requested review from CabinfeverB and removed request for HunDunDM November 20, 2023 03:50
@rleungx
fix data race of tests
b647442 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #7392 (b647442) into master (dda748a) will increase coverage by 0.09%.
Report is 1 commits behind head on master.
The diff coverage is 86.25%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7392      +/-   ##
==========================================
+ Coverage   74.27%   74.36%   +0.09%     
==========================================
  Files         451      451              
  Lines       48967    49046      +79     
==========================================
+ Hits        36372    36475     +103     
+ Misses       9375     9357      -18     
+ Partials     3220     3214       -6
Flag Coverage Δ
unittests 74.36% <86.25%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 20, 2023
@rleungx
Copy link
Member Author

rleungx commented Nov 20, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2023

This pull request has been accepted and is ready to merge.

Commit hash: b647442

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 49b3251 into tikv:master Nov 20, 2023
26 checks passed
@rleungx rleungx deleted the fix-race11 branch November 20, 2023 06:14
@lhy1024 lhy1024 mentioned this pull request Nov 20, 2023
Closed
@rleungx rleungx mentioned this pull request Nov 30, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
*: fix data race of TestRaftClusterMultipleRestart (tikv#7392)
465fbac 
close tikv#7391

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race in TestRaftClusterMultipleRestart
3 participants
@rleungx @lhy1024 @CabinfeverB